Fix panic when a command fails + more #10

2024-10-06T18:40:08Z

sungsphinx commented

2024-10-06 18:40:08 +00:00

(Migrated from github.com)

Apologies for most of this being in one whole commit, I had already done quite a lot of code changes and it would be a pain to split it.

Main changes:

Make wgpu an optional feature (useful for operating systems like Redox OS)
Fix panicking when either lspci, lspcu or lsusb fail
If a command fails, it will try to show the error message on the respective page
Add usbutils to Flatpak, which should make the lsusb command available
Add cosmic-icons to Flatpak

Minor-ish changes:

Make the log/output in the terminal prettier
Change some code to pass clippy
Change "Uh oh, something went wrong" to "An error occurred"
Make the app icon bigger

Fixes #9

Apologies for most of this being in one whole commit, I had already done quite a lot of code changes and it would be a pain to split it. Main changes: - Make wgpu an optional feature (useful for operating systems like Redox OS) - Fix panicking when either lspci, lspcu or lsusb fail - If a command fails, it will try to show the error message on the respective page - Add usbutils to Flatpak, which should make the lsusb command available - Add cosmic-icons to Flatpak Minor-ish changes: - Make the log/output in the terminal prettier - Change some code to pass clippy - Change "Uh oh, something went wrong" to "An error occurred" - Make the app icon bigger Fixes #9

edfloreshz (Migrated from github.com) requested changes

2024-10-06 22:27:58 +00:00

edfloreshz (Migrated from github.com) left a comment

Just a minor change

page.codeberg.sungsphinx.Examine.json

					
				@ -59,6 +59,68 @@

				                }

This entry has some formatting issues.

sungsphinx (Migrated from github.com) reviewed

2024-10-07 16:22:12 +00:00

page.codeberg.sungsphinx.Examine.json

					
				@ -59,6 +59,68 @@

				                }

Should be fixed, unless that's not what you meant 😅

Should be fixed, unless that's not what you meant :sweat_smile:

edfloreshz (Migrated from github.com) approved these changes

2024-10-07 16:50:28 +00:00

edfloreshz (Migrated from github.com) left a comment

LGTM!

sungsphinx commented

2024-10-07 18:02:27 +00:00

(Migrated from github.com)

Should I switch to the cosmic baseapp before merging @edfloreshz?

edfloreshz commented

2024-10-07 18:14:16 +00:00

(Migrated from github.com)

I still haven't gotten it to build, so I wouldn't recommend it just yet.

👍 1

Sign in to join this conversation.

No reviewers

edfloreshz

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sungsphinx/examine!10

				`@ -59,6 +59,68 @@`
				`}`

				`@ -59,6 +59,68 @@`
				`}`

Rows
Columns